[Airship-discuss] Divingbell overrides functionality regression - Assistance needed

[Roman Gorshunov]

Oops, update:
.. with the help of Pete, not Scott. Sorry.

On Wed, Mar 6, 2019 at 5:49 PM Roman Gorshunov <paye600 at gmail.com> wrote:
>
> Hello Craig, team,
>
> With some help from Scott I've found exact commit in dependency of helm - mergo,
> which breaks functionality:
> https://github.com/imdario/mergo/commit/df0700a1e899196d8020767981b82623c8738932
> If line 52 (new one) returns `false`, then everything seems to work again.
>
> Would appreciate any help. Thank you.
>
> Details I have collected are in this Story:
> https://storyboard.openstack.org/#!/story/2005095#comment-117207,
> including some help on how to reproduce the issue and test different
> versions.
>
> Best regards,
> -- Roman Gorshunov
>
> On Thu, Feb 28, 2019 at 5:32 PM ANDERSON, CRAIG <ca846m at att.com> wrote:
> >
> > Ok, our version of Helm must not be new enough to contain the version of Sprig library which has that patchset, so I guess it must be a different issue. But I would still suspect something with `merge` or one of the other changes to dict.go between helm versions.
> >
> > -----Original Message-----
> > From: Roman Gorshunov [mailto:paye600 at gmail.com]
> > Sent: Thursday, February 28, 2019 2:52 AM
> > To: airship-discuss at lists.airshipit.org
> > Cc: TANG, ROY <rt7380 at att.com>; ANDERSON, CRAIG <ca846m at att.com>
> > Subject: Re: Divingbell overrides functionality regression - Assistance needed
> >
> > Hello Craig,
> > Thank you for your reply and support.
> > I have tried to do a quick replace of `merge` to `mergeOverwrite`, and it didn't work. Linting fails on the following error:
> >
> > > [ERROR] templates/: parse error in
> > > "helm-toolkit/templates/utils/_daemonset_overrides.tpl": template:
> > > helm-toolkit/templates/utils/_daemonset_overrides.tpl:52: function
> > > "mergeOvewrite" not defined
> >
> > Best regards,
> > -- Roman Gorshunov