[Airship-discuss] Divingbell overrides functionality regression - Assistance needed

[Roman Gorshunov]

Good news:
Tests on gates have succeeded.
I have formatted a proper patch set which is now ready for review [0].
If applied, this patch will update Helm from v2.12.3 to v2.13.0, and
replace `merge` with `mergeOverwrite` where appropriate in
*daemonset_overrides.tpl files from helm-toolkit and ceph-osd. I'm
actually not sure how to test if changes in *daemonset_overrides.tpl
are correct.

Not so good news:
This didn't help to the divingbell overrides, and they are still not working.
Logs: http://paste.openstack.org/show/747433/

I'm stuck again.

[0] https://review.openstack.org/#/c/641656/5

-- Roman Gorshunov

On Thu, Mar 7, 2019 at 2:17 PM Roman Gorshunov <paye600 at gmail.com> wrote:
>
> Playing a little bit, I have just found out that using helm version
> v2.13.0-rc.1 and higher, AND `mergeOverwrite` allows to pass linting.
> Log: http://paste.openstack.org/show/747402/
>
> I've submitted a test PS to see if it would pass standard voting
> gates: https://review.openstack.org/#/c/641656/
> The non-voting `openstack-helm-infra-airship-divingbell` gate should
> still fail, as it would use old `merge`.
>
> Waiting for gates to complete the work.
>
> -- Roman Gorshunov
>
> On Thu, Mar 7, 2019 at 1:55 PM Roman Gorshunov <paye600 at gmail.com> wrote:
> >
> > > Just to confirm, were you using Helm 1.12.x when you tried replacing `merge` with `mergOverwrite`?
> > I used helm 2.12.3.I confirm that mergeOverwrite does not work.
> >
> > Link with test: http://paste.openstack.org/show/747400/
> > Details:
> > - line  4: helm client version v2.12.3 (this version is used in
> > openstack-helm-infra by default)
> > - line 16: latest openstack-helm-infra (commit id
> > e836707ad070e910d6130eced066bc0e50481d2b)
> > - line 30: `helm lint` of helm-toolkit
> > - line 33: ./templates/utils/_daemonset_overrides.tpl uses `merge`
> > - line 40: replace `merge` with `mergeOverwrite`
> > - line 41: confirm replacement
> > - line 50: linting fails with error `function "mergeOverwrite" not defined`
> >
> > Thank you for your help, Craig.
> >
> > -- Roman Gorshunov